-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Notify - define action as non-dismissing by prop #1847
Milestone
Comments
danikane
changed the title
[PROPOSAL] Notify - define action as non-dismissing by prop
[Enhancement] Notify - define action as non-dismissing by prop
Mar 27, 2018
Which would be the use case for a notification you want to keep visible after selecting an action? |
rstoenescu
added a commit
that referenced
this issue
Mar 30, 2018
Added "noDismiss" prop to actions. Available in 0.15.11. |
Amazing! Thanks, man. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I just saw you're adding an onDismiss handler to Notify, good stuff!
I was wondering whether you could add another prop to the config object for the action items, for example willDismiss, type Boolean, default true.
Currently the code for Notify is like:
Currently any action closes the Notify.
What I suggest is something like:
Turn it around, make it a noDismiss, true and for example
noDismiss ? null : close()
if you think is better approach. :)
I can do a PR if this addition makes sense.
The text was updated successfully, but these errors were encountered: