Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime input, default-view bug #1946

Merged
merged 3 commits into from
Apr 17, 2018
Merged

Datetime input, default-view bug #1946

merged 3 commits into from
Apr 17, 2018

Conversation

Morgosh
Copy link
Contributor

@Morgosh Morgosh commented Apr 17, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix

Does this PR introduce a breaking change? (check one)

  • No

Description
If you check datetime input on quasar documentation. There is an error when you set default-view parameter. The default view is only set on the second click on date. So first time you click it, the default view is not the same as default-view parameter. After the second click it is.

An example bug can be seen in the example itself. Click on the default view row twice, and you get different popout.
http://quasar-framework.org/quasar-play/android/index.html#/showcase/forms/datetime/datetime-input

@rstoenescu rstoenescu merged commit f73dea2 into quasarframework:dev Apr 17, 2018
@rstoenescu rstoenescu added this to the 0.15.11 milestone Apr 17, 2018
@rstoenescu
Copy link
Member

Thanks for contributing! This will get into 0.15.11

@KnowZero
Copy link

@rstoenescu I don't think default-view is completely fixed. It is acting really odd.

http://quasar-framework.org/quasar-play/android/index.html#/showcase/forms/datetime/datetime-input

When I visit on desktop chrome or firefox the demo page which has default view set to "month" and click on it, it shows "day" no matter how many times I click on it. Now if I lose focus by click on a different field or click on the page 2 times and click it again, it only then shows "month" properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants