Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javascript setMonth() glitch when moving between months of differ… #850

Closed
wants to merge 4 commits into from

Conversation

dsl101
Copy link
Contributor

@dsl101 dsl101 commented Sep 1, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@dsl101
Copy link
Contributor Author

dsl101 commented Sep 1, 2017

Aargh. Sorry - just noticed it doesn't handle the year wraparound (Dec 2017 → Jan 2018, etc.). I will work on another revision...

@dsl101
Copy link
Contributor Author

dsl101 commented Sep 1, 2017

OK - I think that's got it. Just taking the __mod() in the wrong place.

@rstoenescu
Copy link
Member

Hi,

First of all, thank you for taking time for this PR! While checking out the source code, I have also discovered same glitches in "date" utils and went for another approach (I hope you don't mind).

@rstoenescu rstoenescu closed this Sep 3, 2017
@dsl101
Copy link
Contributor Author

dsl101 commented Sep 4, 2017

No problem at all - just glad it's fixed. Also glad to see the force parameter has disappeared. I could not figure out what it was there for :).

@dsl101 dsl101 deleted the datefix branch March 2, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants