Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size attr to manage the size (in col) of each message. #977

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

sebastienroul
Copy link
Contributor

@sebastienroul sebastienroul commented Oct 9, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Add a new attribute to set the size of the message. Today, the size is automatic, then I let it automatic if not set. If arrt size is specified : from 1 to 12, the col-X class is added to set the size.
Very usefull for enterprise/business message displayed on desktop mode (ie. large width for the chat section) - it make the reading more confortable.

@rstoenescu rstoenescu merged commit fd0f233 into quasarframework:dev Oct 9, 2017
@rstoenescu
Copy link
Member

Thanks for also doing a doc PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants