Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Helper Positioning Class - .absolute-center #987

Merged
merged 2 commits into from
Oct 20, 2017
Merged

CSS Helper Positioning Class - .absolute-center #987

merged 2 commits into from
Oct 20, 2017

Conversation

SeregPie
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Standard approach to center absolute positioned element.

https://stackoverflow.com/a/23384995/1785975

@SeregPie
Copy link
Contributor Author

I also can update the docs, if needed.

@rstoenescu rstoenescu added this to the v0.14.7 milestone Oct 20, 2017
@rstoenescu rstoenescu merged commit 964e93c into quasarframework:dev Oct 20, 2017
@rstoenescu
Copy link
Member

Yes, please do a PR on docs too. Added "fixed-center" too.

rstoenescu pushed a commit that referenced this pull request Oct 20, 2017
* Update positioning.styl

* Update positioning.styl
@SeregPie
Copy link
Contributor Author

Oh yes. Thank you. I forgot about fixed. But you forgot to add position: fixed too.

^^

positioning.styl#L11

@rstoenescu
Copy link
Member

Right. Added it. Please help with a docs PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants