Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update min Go version #481

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Aug 23, 2024

Fixes #480

I didn't find a way to have a working approach for GO111MODULE=off tests, so I removed them (and I tried several approaches).

make test-master
$ make test-master
cd _test/install/gitclone && docker build --no-cache .
[+] Building 98.8s (8/8) FINISHED                                                                                                                                                                                                                      docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                             0.0s
 => => transferring dockerfile: 105B                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/library/golang:1.22-alpine                                                                                                                                                                                            0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                  0.0s
 => [internal] load build context                                                                                                                                                                                                                                0.0s
 => => transferring context: 1.35kB                                                                                                                                                                                                                              0.0s
 => CACHED [1/3] FROM docker.io/library/golang:1.22-alpine                                                                                                                                                                                                       0.0s
 => [2/3] COPY . /root                                                                                                                                                                                                                                           0.0s
 => [3/3] RUN /root/test.bash                                                                                                                                                                                                                                   97.5s
 => exporting to image                                                                                                                                                                                                                                           1.2s
 => => exporting layers                                                                                                                                                                                                                                          1.2s
 => => writing image sha256:cc2012ef87de70e46fca157e0290fff9a799f319be06a805165fa627ef5666fb                                                                                                                                                                     0.0s 
cd _test/regress/issue103 && docker build --no-cache .                                                                                                                                                                                                                
[+] Building 10.4s (8/8) FINISHED                                                                                                                                                                                                                      docker:default 
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                             0.0s 
 => => transferring dockerfile: 105B                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/library/golang:1.22-alpine                                                                                                                                                                                            0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                  0.0s
 => [internal] load build context                                                                                                                                                                                                                                0.0s
 => => transferring context: 5.59kB                                                                                                                                                                                                                              0.0s
 => CACHED [1/3] FROM docker.io/library/golang:1.22-alpine                                                                                                                                                                                                       0.0s
 => [2/3] COPY . /root                                                                                                                                                                                                                                           0.0s
 => [3/3] RUN /root/test.bash                                                                                                                                                                                                                                    9.4s
 => exporting to image                                                                                                                                                                                                                                           0.9s 
 => => exporting layers                                                                                                                                                                                                                                          0.9s 
 => => writing image sha256:33a7e0284a4e1d92fd02a921b8617cc6347b1f8547533a4a5124f928727549ee                                                                                                                                                                     0.0s 
cd _test/regress/issue193 && docker build --no-cache .                                                                                                                                                                                                                
[+] Building 11.0s (8/8) FINISHED                                                                                                                                                                                                                      docker:default 
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                             0.0s 
 => => transferring dockerfile: 105B                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/library/golang:1.22-alpine                                                                                                                                                                                            0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                  0.0s
 => [internal] load build context                                                                                                                                                                                                                                0.0s
 => => transferring context: 11.08kB                                                                                                                                                                                                                             0.0s
 => CACHED [1/3] FROM docker.io/library/golang:1.22-alpine                                                                                                                                                                                                       0.0s
 => [2/3] COPY . /root                                                                                                                                                                                                                                           0.0s
 => [3/3] RUN /root/test.bash                                                                                                                                                                                                                                   10.2s
 => exporting to image                                                                                                                                                                                                                                           0.7s
 => => exporting layers                                                                                                                                                                                                                                          0.7s
 => => writing image sha256:34454dce5b5ad005b158374a0726a95b6b6130008780719aa84030d133a5e736                                                                                                                                                                     0.0s 
cd _test/regress/issue317 && docker build --no-cache .                                                                                                                                                                                                                
[+] Building 12.1s (8/8) FINISHED                                                                                                                                                                                                                      docker:default 
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                             0.0s 
 => => transferring dockerfile: 105B                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/library/golang:1.22-alpine                                                                                                                                                                                            0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                  0.0s
 => [internal] load build context                                                                                                                                                                                                                                0.0s
 => => transferring context: 1.40kB                                                                                                                                                                                                                              0.0s
 => CACHED [1/3] FROM docker.io/library/golang:1.22-alpine                                                                                                                                                                                                       0.0s
 => [2/3] COPY . /root                                                                                                                                                                                                                                           0.0s
 => [3/3] RUN /root/test.bash                                                                                                                                                                                                                                   11.4s
 => exporting to image                                                                                                                                                                                                                                           0.6s
 => => exporting layers                                                                                                                                                                                                                                          0.6s
 => => writing image sha256:a26bd96f0f4d56bd4c9bfc909b0d95f5145d93a7ea5ba63a4ff0e1c6106b168f                                                                                                                                                                     0.0s 
everything is OK                                    
make test-release
$ make test-release
cd _test/install/binary_nogopath && docker build --build-arg release=v0.3.18 --no-cache .
[+] Building 10.0s (8/8) FINISHED                                                                                                                                                                                                                      docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                             0.0s
 => => transferring dockerfile: 126B                                                                                                                                                                                                                             0.0s
 => [internal] load metadata for docker.io/library/golang:1.22-alpine                                                                                                                                                                                            0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                                0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                  0.0s
 => [internal] load build context                                                                                                                                                                                                                                0.0s
 => => transferring context: 3.03kB                                                                                                                                                                                                                              0.0s
 => CACHED [1/3] FROM docker.io/library/golang:1.22-alpine                                                                                                                                                                                                       0.0s
 => [2/3] COPY . /root                                                                                                                                                                                                                                           0.0s
 => [3/3] RUN /root/test.bash v0.3.18                                                                                                                                                                                                                            9.5s
 => exporting to image                                                                                                                                                                                                                                           0.5s
 => => exporting layers                                                                                                                                                                                                                                          0.5s
 => => writing image sha256:988dcff0b9f196a3f53f47d36c62ceabaaec59980522c986ddd9884e1e416f2a                                                                                                                                                                     0.0s 
everything is OK      

@ldez ldez marked this pull request as ready for review August 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure: undefined: types.Alias/types.Unalias
1 participant