TS Support #10
Merged
TS Support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusccastroo
force-pushed
the
ts-support
branch
from
6bf64dc to
eea0b56
Compare
matheusccastroo
force-pushed
the
ts-support
branch
from
eea0b56 to
dd88ca9
Compare
renanccastro
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the
walkerfor parsingtsandtsxfiles. It also add a flag to ignore thecache.The way to support typescript is to simply compile it before parsing it with
babel.parsewith thetypescriptcompiler. We can't really use the babel typescript plugin/preset because it can still cause compilation errors and it would conflict with theflowplugin that comes from the babel options fromreify.We also added the flag
METEOR_ESLINT_PLUGIN_IGNORE_CACHEto allow the user to ignore or not the cache. This is needed because there seems to be a race condition between the 2 rules that uses thewalker, and the end result is the cache file empty. I think this happens only in larger projects because ESLint might run the rules concurrently. I tested with the TS meteor sample and it worked with the cache without a problem.