Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startupProbe and readinessProbe should use the readyz endpoint #1488

Closed
iainduncani opened this issue Feb 10, 2022 · 0 comments · Fixed by #1489
Closed

startupProbe and readinessProbe should use the readyz endpoint #1488

iainduncani opened this issue Feb 10, 2022 · 0 comments · Fixed by #1489

Comments

@iainduncani
Copy link
Contributor

Description of Problem / Feature Request

Since the /readyz endpoint was introduced I would expect any checks on startup and readiness to use them but the openshift manifest does not.

Expected Outcome

The readinessProbe and startupProbe to use the /readyz health endpoint.

Actual Outcome

They use the healthz endpoint.

Environment

  • Clair version/image: main
  • Clair client name/version: main
  • Host OS: n/a
  • Kernel (e.g. uname -a): n/a
  • Kubernetes version (use kubectl version): all
  • Network/Firewall setup: n/a
iainduncani added a commit to iainduncani/clair that referenced this issue Feb 10, 2022
@iainduncani
contrib: Use the readyz endpoint in startup probes
bcf1c16 
Fixes quay#1488
@iainduncani iainduncani mentioned this issue Feb 10, 2022
Merged
iainduncani added a commit to iainduncani/clair that referenced this issue Feb 10, 2022
@iainduncani
contrib: Use the readyz endpoint in startup probes
2ade5a3 
Fixes quay#1488

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
iainduncani added a commit to iainduncani/clair that referenced this issue Feb 11, 2022
@iainduncani
contrib: Use the readyz endpoint in startup probes
778ade0 
Fixes quay#1488

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
iainduncani added a commit to iainduncani/clair that referenced this issue Mar 18, 2022
@iainduncani
contrib: Use the readyz endpoint in startup probes
e0a134f 
Fixes quay#1488

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
iainduncani added a commit to iainduncani/clair that referenced this issue Mar 18, 2022
@iainduncani
contrib: Use the readyz endpoint in startup probes
e1049d0 
Fixes quay#1488

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
crozzy pushed a commit that referenced this issue Mar 18, 2022
@iainduncani @crozzy
contrib: Use the readyz endpoint in startup probes
ae7675a 
Fixes #1488

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

contrib: Use the readyz endpoint in startup probes iainduncani/clair
1 participant
@iainduncani