Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto: improve log messages #2093

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Jul 12, 2024

Adds some helpers and improves logging around missing cgroup interface files.

See-also: #2092

@hdonnay hdonnay requested a review from a team as a code owner July 12, 2024 19:36
@hdonnay hdonnay requested review from crozzy and removed request for a team July 12, 2024 19:36
crozzy
crozzy previously approved these changes Jul 15, 2024
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, one comment, feel free to merge as is

initialize/auto/cpu_linux.go Outdated Show resolved Hide resolved
Adds some helpers and improves logging around missing cgroup interface
files.

See-also: quay#2092
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdonnay
Copy link
Member Author

hdonnay commented Jul 15, 2024

/fast-forward

@github-actions github-actions bot merged commit 07b0ea7 into quay:main Jul 15, 2024
10 checks passed
@hdonnay hdonnay deleted the hack/auto-errors branch July 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants