Fix to update cluster nodes in consistent hash ring in getCurrentNode…

…Name (#467)
qubole · Oct 7, 2020 · 46c8440 · 46c8440
1 parent c82bd58
commit 46c8440
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/rubix-spi/src/main/java/com/qubole/rubix/spi/ClusterManager.java b/rubix-spi/src/main/java/com/qubole/rubix/spi/ClusterManager.java
@@ -166,14 +166,18 @@ public List<String> getNodes()
 
   public String getCurrentNodeName()
   {
-    if (currentNodeName == null) {
-      // getNodes() updates the currentNodeName
-      List<String> nodes = getNodes();
-      if (nodes == null) {
-        log.error("Initialization not done for Cluster Type: " + getClusterType());
-        throw new RuntimeException("Unable to find current node name");
-      }
-    }
+    // refresh cluster nodes first, which updates currentNodeName if it is not set.
+    refreshClusterNodes();
     return currentNodeName;
   }
+
+  private void refreshClusterNodes()
+  {
+    // getNodes() updates the currentNodeName
+    List<String> nodes = getNodes();
+    if (nodes == null) {
+      log.error("Initialization not done for Cluster Type: " + getClusterType());
+      throw new RuntimeException("Unable to find current node name");
+    }
+  }
 }