fix double check lock on cluster manager #457
Conversation
| @@ -110,7 +110,7 @@ | |||
|
|
|||
| protected static Cache<String, FileMetadata> fileMetadataCache; | |||
| private static LoadingCache<String, FileInfo> fileInfoCache; | |||
| protected ClusterManager clusterManager; | |||
| protected volatile ClusterManager clusterManager; | |||
There was a problem hiding this comment.
can you please describe the issue?
There was a problem hiding this comment.
I see usecase similar to this comment.
There was a problem hiding this comment.
I see, if possible can we go with early initialization as mentioned in some other links?
Using volatile may have adverse performance implications. So, if we can avoid it may be by creating a rubix config to tell it before starting the cluster type and then we do an early initialization. This way we may get rid of double lock check pattern.
There was a problem hiding this comment.
We dont have a good way of initializing objects in rubix because of they way rubix integrates with engine. It gets added as a library and there is no separate initialisation phase for rubix. It is possible in embedded mode where there is a initialisation phase but not generally.
I will merge this change, in case you have ideas about doing it the other way please open a new issue.
No description provided.