fix lint issues

.golangci.yml

@@ -137,3 +137,9 @@ linters-settings:
       - name: unused-parameter
         severity: warning
         disabled: false
+
+issues:
+  exclude-rules:
+    - path: '(.+)_test\.go'
+      text: "dot-imports: should not use dot imports"
+

internal/logger/logger.go

@@ -78,7 +78,7 @@ func NewLogger(level string, onError func(err error, args ...interface{})) Logge
 }
 
 func NewNopLogger() Logger {
-	noopErrorCallback := func(err error, args ...interface{}) {}
+	noopErrorCallback := func(_ error, _ ...interface{}) {}
 
 	return &loggerImpl{logger: gokitlog.NewNopLogger(), errorCallback: noopErrorCallback}
 }

pkg/controllers/logql_validator_test.go

@@ -66,7 +66,7 @@ func TestValidateLogQLOnServerWithHeadersFunc(t *testing.T) {
 }
 
 func TestValidateLogQLOnServerFuncHTTP500IsAnInvalidResponse(t *testing.T) {
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(http.StatusInternalServerError)
 	}))
 
@@ -84,7 +84,7 @@ func TestValidateLogQLOnServerFuncHTTP500IsAnInvalidResponse(t *testing.T) {
 }
 
 func TestValidateLogQLOnServerFuncInvalidRequest(t *testing.T) {
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(500)
 	}))
 	isValid, err := ValidateLogQLOnServerFunc(http.DefaultClient, ts.URL, "{job=\"loki-test\"}")

pkg/controllers/lokirule_controller_test.go

@@ -79,7 +79,7 @@ var _ = BeforeSuite(func() {
 	})
 	Expect(err).ToNot(HaveOccurred())
 
-	httpServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	httpServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 		w.WriteHeader(http.StatusOK)
 	}))
 
@@ -113,6 +113,10 @@ var _ = BeforeSuite(func() {
 	}()
 })
 
+var _ = AfterSuite(func() {
+	defer httpServer.Close()
+})
+
 var _ = Describe("LokiRuleController", func() {
 	Describe("Reconcile", func() {
 		Context("When a LokiRule is created", func() {