WIP: Port to Nulls #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Oct 6, 2017
| if iter.parameters[1].parameters[i] <: DataValue | ||
| push!(constructor_call.args, :(DataValue(columns[$i][i]))) | ||
| if iter.parameters[1].parameters[i] >: Null | ||
| push!(constructor_call.args, :(isnull(columns[$i][i]) ? null : get(columns[$i][i]))) |
nalimilan
reviewed
Oct 6, 2017
| @@ -80,7 +80,7 @@ end | |||
| push_exprs = Expr(:block) | |||
| for i in 1:n | |||
| if tt.parameters[2].parameters[i] <: NullableArray | |||
| ex = :( push!(tt.data[$i], Nullable(row[$i]) )) | |||
| ex = :( push!(tt.data[$i], isnull(row[$i]) ? Nullable() : Nullable(row[$i]) )) | |||
There was a problem hiding this comment.
Should use Nullable{typeof(row[$i])}() or something equivalent to ensure type stability.
|
I guess this should require DataFrames 0.11, Nulls 0.1.0 and StatsModels 0.1.0 (once these releases exist)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to
jq/nullsbranch for Query.jl.Status: Got most of the tests passing locally, though had trouble getting all the test dependencies installed (VegaLite mainly). There was a failure in the differentialequations.jl test file that I didn't quite follow and haven't had time to look into. We're also waiting on this PR for StatsModel.
I went ahead and removed DataTables since the package is deprecated now.