Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/validation errors #126

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Feat/validation errors #126

wants to merge 6 commits into from

Commits on Oct 31, 2024

  1. fix: correct location in group and section ValidationErrors

    @MHajoha @tumidi
    MHajoha authored and tumidi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    40d0030 View commit details
    Browse the repository at this point in the history

  2. fix: set min_length for required text_input and text_area 

    A text input with no content should be considered unfilled.
    @MHajoha @tumidi
    MHajoha authored and tumidi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    45666fe View commit details
    Browse the repository at this point in the history

  3. test: test for correct ValidationError loc and min length

    @MHajoha @tumidi
    MHajoha authored and tumidi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8dae7be View commit details
    Browse the repository at this point in the history

  4. test: add `test_should_raise_options_form_validation_error_when_creat… 

    …ing_question_from_invalid_options`
    @tumidi
    tumidi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3c12435 View commit details
    Browse the repository at this point in the history

  5. feat: show options validation errors 

    Closes #119
    @tumidi
    tumidi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b663ba6 View commit details
    Browse the repository at this point in the history

  6. test: add test_shows_validation_errors E2E test 

    Ref: #119
    @tumidi
    tumidi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    29912da View commit details
    Browse the repository at this point in the history