feat: display web server URL in console when executing run command
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbonczek
reviewed
Oct 25, 2024
| @@ -84,6 +87,7 @@ async def start_server(self) -> None: | |||
| self._runner = web.AppRunner(self._web_app) | |||
| await self._runner.setup() | |||
| await web.TCPSite(self._runner, self._host, self._port).start() | |||
| self._print_urls() | |||
There was a problem hiding this comment.
Was spricht dagegen, einfach nur f"http://{self._host}:{self._port}" auszugeben?
There was a problem hiding this comment.
Das würde nicht alle Adressen auflisten, auf dem der Webserver horcht:
$ questionpy-sdk run examples/minimal
INFO:questionpy-sdk:web-server:Webserver started: http://[::1]:8080 http://127.0.0.1:8080
versus
$ questionpy-sdk run examples/minimal
INFO:questionpy-sdk:web-server:Webserver started: http://localhost:8080
There was a problem hiding this comment.
Schon klar, aber ist das nötig? Bei den anderen Tools die ich kenne, die mir ihre URL in der Konsole ausgeben, wird mir immer nur eine angezeigt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zeigt die URLs vom Dev-Server an, wenn der
run-Befehl verwendet wird.