introduce an assertion in the server #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2637 +/- ##
==========================================
+ Coverage 86.29% 86.39% +0.10%
==========================================
Files 121 121
Lines 9775 10118 +343
==========================================
+ Hits 8435 8741 +306
- Misses 998 1027 +29
- Partials 342 350 +8
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jul 1, 2020
server.go
Outdated
| @@ -322,7 +322,7 @@ func (s *baseServer) handlePacketImpl(p *receivedPacket) bool /* should the buff | |||
| } | |||
| // Short header packets should never end up here in the first place | |||
| if !hdr.IsLongHeader { | |||
| return false | |||
| panic("misrouted packet") | |||
There was a problem hiding this comment.
Do we want a few more debug details?
marten-seemann
force-pushed
the
server-assertion
branch
from
ce864fc
to
7bcb25f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.