use batched reads #3142
Merged
use batched reads #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
batched-read
branch
5 times, most recently
from
1c18c35
to
336374c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3142 +/- ##
==========================================
+ Coverage 85.40% 85.43% +0.02%
==========================================
Files 134 134
Lines 9825 9840 +15
==========================================
+ Hits 8391 8406 +15
Misses 1060 1060
Partials 374 374
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Apr 30, 2021
| oobBuffer: make([]byte, 128), | ||
| }, nil | ||
| batchConn: ipv4.NewPacketConn(c), | ||
| messages: make([]ipv4.Message, batchSize), |
There was a problem hiding this comment.
Maybe it's a bit less error-prone if you keep a [batchSize]ipv4.Message array and a currentMessages slice over that as members? That could allow you to get rid of the readPos tracking…
marten-seemann
force-pushed
the
batched-read
branch
from
336374c
to
870c759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.