Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce allocations when handling crypto data #4615

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

marten-seemann
Copy link
Member

Closes #4614. Part of #3663.

name          old time/op    new time/op    delta
Handshake-16     612µs ± 2%     609µs ± 3%    ~     (p=0.172 n=14+15)

name          old alloc/op   new alloc/op   delta
Handshake-16     244kB ± 0%     243kB ± 0%  -0.43%  (p=0.000 n=13+14)

name          old allocs/op  new allocs/op  delta
Handshake-16     2.50k ± 0%     2.50k ± 0%  -0.16%  (p=0.002 n=15+15)

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (b8ea5c7) to head (263beb6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4615      +/-   ##
==========================================
+ Coverage   85.18%   85.19%   +0.01%     
==========================================
  Files         151      151              
  Lines       14764    14757       -7     
==========================================
- Hits        12576    12571       -5     
+ Misses       1679     1678       -1     
+ Partials      509      508       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit bb4eb85 into master Aug 3, 2024
42 checks passed
@marten-seemann marten-seemann deleted the reduce-crypto-stream-allocs branch August 3, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant