Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: send GOAWAY when server is shutting down #4691

Merged
merged 8 commits into from
Oct 12, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Oct 10, 2024

Continuation of #4669. Part of #153.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 36 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (e5693d0) to head (674c49f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
http3/server.go 63.64% 33 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4691      +/-   ##
==========================================
- Coverage   84.79%   84.60%   -0.19%     
==========================================
  Files         150      150              
  Lines       14929    15024      +95     
==========================================
+ Hits        12658    12710      +52     
- Misses       1742     1782      +40     
- Partials      529      532       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the graceful-shutdown branch 2 times, most recently from f83bfff to 49361b0 Compare October 11, 2024 04:07
@marten-seemann marten-seemann changed the title http: send GOAWAY when server is shutting down http3: send GOAWAY when server is shutting down Oct 11, 2024
@marten-seemann
Copy link
Member Author

This should be ready to go now.

@marten-seemann marten-seemann merged commit eaa879f into master Oct 12, 2024
35 checks passed
@marten-seemann marten-seemann deleted the graceful-shutdown branch October 12, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants