handshake: lazily create the AEAD used for Retry #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4916 +/- ##
==========================================
+ Coverage 83.55% 83.65% +0.11%
==========================================
Files 151 152 +1
Lines 16223 16254 +31
==========================================
+ Hits 13554 13597 +43
+ Misses 2138 2132 -6
+ Partials 531 525 -6 ☔ View full report in Codecov by Sentry. |
internal/handshake/retry.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| func initRetry() { |
There was a problem hiding this comment.
Please add a comment here, explaining why this isn't done in init. It's probably also a good idea to link to your issue.
tmthrgd
reviewed
Jan 23, 2025
marten-seemann
approved these changes
Jan 23, 2025
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the init for retry to a sync.Once, like this, ciphers are only init if you use it.
Linked to #4894