use a buffered channel in the acceptQueue #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a race condition here. A user might call Next to obtain the next stream, and get a nil result. He then calls Chan get notified about new incoming streams. If a new stream is accepted between the call to Next and the call to Chan, he won't be notified about that stream, unless the channel is buffered.
3 tasks
MarcoPolo
approved these changes
Dec 8, 2022
This was referenced Dec 8, 2022
|
@marten-seemann ; Is there a way to add a regression test for this? |
|
A few of the tests here were flaky before this fix. As this is a race condition, this is probably all we can ask for. And again shows the value of debugging flaky tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a race condition here. A user might call
Nextto obtain the next stream, and get a nil result. He then callsChanget notified about new incoming streams. If a new stream is accepted between the call toNextand the call toChan, he won't be notified about that stream, unless the channel is buffered.