Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronise sending streamHeader #78

Merged
merged 3 commits into from
May 18, 2023

Conversation

sukunrt
Copy link
Contributor

@sukunrt sukunrt commented May 17, 2023

There is a race when sending stream header between Write and Close calls on sendStream

@google-cla
Copy link

google-cla bot commented May 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@marten-seemann marten-seemann self-requested a review May 17, 2023 16:10
stream.go Outdated
Comment on lines 61 to 63
if len(s.streamHdr) == 0 {
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this check any more, do you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. Removed it.

@marten-seemann
Copy link
Member

Test case seems to be flaky:

=== RUN   TestWriteCloseRace
    webtransport_test.go:88: 
        	Error Trace:	/Users/runner/work/webtransport-go/webtransport-go/webtransport_test.go:88
        	            				/Users/runner/work/webtransport-go/webtransport-go/webtransport_test.go:583
        	Error:      	Received unexpected error:
        	            	timeout: no recent network activity
        	Test:       	TestWriteCloseRace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants