Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the WebTransport offer header if already set #81

Merged

Conversation

lleyton
Copy link
Contributor

@lleyton lleyton commented May 25, 2023

Dialer.Dial currently adds a new HTTP header (with key set in webTransportDraftOfferHeaderKey) to the passed headers object when called. This can cause issues if the header is already set, which may happen if you're retrying the Dial call reusing the same headers object.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. This makes sense, thank you for the PR!

@marten-seemann marten-seemann changed the title Set webTransportDraftOfferHeaderKey rather than add replace the WebTransport offer header if already set Jul 8, 2023
@marten-seemann marten-seemann merged commit ed254ba into quic-go:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants