Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create custom class for no exist attribute in patch_attr #2806

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Create custom class for no exist attribute in patch_attr #2806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions TrainingExtensions/torch/src/python/aimet_torch/experimental/v2/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@ def patch_attr(obj, attr_name, new_attr)-> _ContextManager:
if attr_name in obj._parameters or attr_name in obj._buffers: # pylint: disable=protected-access
return _patch_param_or_buffer(obj, attr_name, new_attr)

old_attr = getattr(obj, attr_name, None)
class _NullAttribute:
pass

old_attr = getattr(obj, attr_name, _NullAttribute())
action = lambda: setattr(obj, attr_name, new_attr)

def cleanup():
Expand All @@ -127,7 +130,7 @@ def cleanup():
except AttributeError:
pass

if not hasattr(obj, attr_name) and old_attr is not None:
if not hasattr(obj, attr_name) and not isinstance(old_attr, _NullAttribute):
setattr(obj, attr_name, old_attr)

return _ContextManager(action, cleanup)
Expand Down
5 changes: 5 additions & 0 deletions TrainingExtensions/torch/test/python/experimental/v2/test_utils_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,8 @@ def test_patch_attr():

replica = conv._replicate_for_data_parallel()
assert replica.forward.__self__ is replica

with patch_attr(conv, 'no_exist_attribute', 1):
assert conv.no_exist_attribute == 1

assert not hasattr(conv, 'no_exist_attribute')
Loading