Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Manjaro Linux #47

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

daPhipz
Copy link
Member

@daPhipz daPhipz commented Jan 1, 2022

See https://github.com/quickemu-project/quickemu/pull/296/files

@ymauray @marxjohnson Do you need a distinctly named icon per Manjaro edition, or does this work for you as it is right now?

@Lukewh
Copy link
Contributor

Lukewh commented Jan 6, 2022

I think this should be fine as a step 1 as the fallback is to the distro-name (split on the -)

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Lukewh Lukewh merged commit 6e03315 into quickemu-project:main Jan 6, 2022
@daPhipz daPhipz deleted the add-manjaro branch February 13, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants