Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test_isos function #1015

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: test_isos function #1015

merged 1 commit into from
Apr 16, 2024

Conversation

zen0bit
Copy link
Contributor

@zen0bit zen0bit commented Apr 15, 2024

No description provided.

@TuxVinyards
Copy link
Contributor

TuxVinyards commented Apr 16, 2024 •
edited
Loading 

            elif [[ "${OS}" == *"ubuntu"* ]]; then
                URL=$(get_ubuntu)

I think this is where the problem I spotted earlier comes from. This won't call get_kubuntu, lubuntu , xubuntu etc

Try URL=$(get_"${OS}" )

flexiondotorg
flexiondotorg requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment from @TuxVinyards

@flexiondotorg flexiondotorg merged commit 6028a61 into quickemu-project:master Apr 16, 2024
@zen0bit zen0bit deleted the AF10 branch April 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexiondotorg flexiondotorg flexiondotorg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zen0bit @TuxVinyards @flexiondotorg