Implemented a foundation for gRPC streaming #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3189968399
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 22.31% 25.29% +2.98%
==========================================
Files 88 89 +1
Lines 10416 10425 +9
==========================================
+ Hits 2324 2637 +313
+ Misses 7819 7494 -325
- Partials 273 294 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
meling
reviewed
Sep 28, 2022
web/interceptor/user_auth.go
Outdated
|
|
||
| func (u *UserInterceptor) WrapStreamingHandler(next connect.StreamingHandlerFunc) connect.StreamingHandlerFunc { | ||
| return connect.StreamingHandlerFunc(func(ctx context.Context, conn connect.StreamingHandlerConn) error { | ||
| cookie := conn.RequestHeader().Get(auth.Cookie) |
There was a problem hiding this comment.
Most of this code is similar to WrapUnary. Can we make a shared function that can be called from both?
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
meling
reviewed
Sep 28, 2022
CloseBy() has no error to return; just returned nil. Calling Run() in TestStreamClose() can ignore the error; we are not interested in the error in this test.
meling
requested changes
Oct 4, 2022
web/stream/service.go
Outdated
| return stream | ||
| } | ||
|
|
||
| func (s *Service[T]) AddStream(userID uint64, st StreamInterface[T]) StreamInterface[T] { |
There was a problem hiding this comment.
Missing doc comment. Also note that since the StreamInterface has GetID we don't actually need to provide the userID argument for this method.
Would it be better to rename st to stream?
There was a problem hiding this comment.
That said, if we can remove this method, then we could simplify the StreamInterface by removing the GetID method. But maybe I'm not seeing all uses of this...
| for _, data := range s.Messages { | ||
| msgMsp[data.Msg]++ | ||
| } | ||
| t.Log(msgMsp) |
There was a problem hiding this comment.
Once we feel comfortable that the test is working as expected, maybe we should remove the printing.
| go func() { | ||
| defer wg.Done() | ||
| err := st.Run() | ||
| t.Log(err) |
There was a problem hiding this comment.
Once we feel comfortable that the test is working as expected, maybe we should remove the printing.
…to submission-stream
`Add` no longer returns a stream
We can just use the userID when adding to the map; we don't need to associate the userID with the stream object itself since it is already a key to the map. Callers must now use st := NewStream(ctx, stream) and Add(st, userID).
meling
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.