Fix timing to set default application version ID at initiator side #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siburu
commented
Apr 3, 2015
siburu
commented
- There are (at least) 2 threads at each host.
- IO thread : Receives a message from an opposite and put it onto queue.
- Application thread : Takes the message from the queue and processes it.
- Probelm in the original implementation
- At initiator side, Application thread sets default application version ID when receiving a first LOGON message.
- IO thread needs default application version ID to be set to parse incoming messages.
- If IO thread attempts to parse a message before Application thread sets default application version ID, it causes error.
- Fixed version
- At initiator side, IO thread sets default application version ID when receiving a first LOGON message.
- By the way, at acceptor side, IO thread sets default application version ID from the beginning.
- There are (at least) 2 threads at each host.
- IO thread : Receives a message from an opposite and put it onto queue.
- Application thread : Takes the message from the queue and processes it.
- Original implementation
- At initiator side, _Application thread_ sets default application version ID when receiving a first LOGON message.
- IO thread needs default application version ID to be set to parse incoming messages.
- If IO thread attempts to parse a message before Application thread sets default application version ID, it causes error.
- Fixed version
- At initiator side, _IO thread_ sets default application version ID when receiving a first LOGON message.
- By the way, at acceptor side, IO thread sets default application version ID from the beginning.
|
Hi, |
chrjohn
added a commit
that referenced
this pull request
Apr 5, 2015
Fix timing to set default application version ID at initiator side
chrjohn
added a commit
that referenced
this pull request
Apr 5, 2015
Fix timing to set default application version ID at initiator side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.