QFJ-722: Optimize unnecessary trailer and header allocations #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwhiuk
reviewed
Jul 30, 2019
chrjohn
approved these changes
Aug 12, 2019
ljagadeesh06
pushed a commit
to ljagadeesh06/quickfixj
that referenced
this pull request
Feb 26, 2020
jli8000
pushed a commit
to jli8000/quickfixj
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about this. In fact it removes unnecessary allocations, but also touches fragile part of code generation?
Up to you!
BTW. It is shame that we have so many constructors in Message created just for unit tests. Ones that take String should be at most static factory method or completly removed.