Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QFJ-375 - configurable timeout multiplier #288

Merged
merged 3 commits into from
May 19, 2020
Merged

QFJ-375 - configurable timeout multiplier #288

merged 3 commits into from
May 19, 2020

Conversation

the-thing
Copy link
Contributor

Fixes QFJ-375

Changes

  • session timeout multiplier is configurable (default values retained)
  • documentation update

the-thing
the-thing commented May 15, 2020
View reviewed changes
quickfixj-core/src/main/doc/usermanual/usage/configuration.html
@@ -1285,11 +1285,21 @@ <H3>QuickFIX Settings</H3>
<TR ALIGN="left" VALIGN="middle">
<TD><I>TestRequestDelayMultiplier</I></TD>
<TD>Fraction of the heartbeat interval which defines the additional time to wait
if a TestRequest sent after a missing heartbeat times out.
if a TestRequest sent after a missing heartbeat times out (final coefficient value is equal to
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I made it worst by clarifying the final coefficient values as for TestRequestDelayMultiplier there is also number of requests variable which might require to look in in the code anyway.

the-thing
the-thing commented May 15, 2020
View reviewed changes
quickfixj-core/src/main/doc/usermanual/usage/configuration.html
HeartBeatTimeoutMultiplier + 1.0).
</TD>
<TD>any non-negative value</TD>
<TD>1.4</TD>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default hardcoded values was 2.4, but +1 is always done in the code the same as for TestRequestDelayMultiplier

the-thing
the-thing commented May 15, 2020
View reviewed changes
quickfixj-core/src/main/doc/usermanual/usage/configuration.html
</TD>
<TD>0..1</TD>
<TD>any non-negative value</TD>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has only informative value as there were no checks anyway.

@the-thing
Copy link
Contributor Author

Is it worth turning LGTM JavaScript off (if possible)?

@the-thing the-thing marked this pull request as ready for review May 15, 2020 10:38
@chrjohn
Copy link
Member

chrjohn commented May 19, 2020

Hi @the-thing , thanks for the PR.
Re LGTM: #277 (comment)
I have asked them in their forum to disable JavaScript checking some weeks ago. But they did not reply.

@the-thing
Copy link
Contributor Author

I see, thanks. Strange that they don't support it.

@the-thing the-thing requested a review from chrjohn May 19, 2020 15:40
@the-thing the-thing requested a review from chrjohn May 19, 2020 20:33
@chrjohn chrjohn added this to the QFJ 2.2.0 milestone May 19, 2020
@chrjohn chrjohn merged commit 5a31fcd into quickfix-j:master May 19, 2020
@the-thing the-thing deleted the QFJ-375/timeout_multiplier branch May 20, 2020 08:12
jli8000 pushed a commit to jli8000/quickfixj that referenced this pull request Sep 22, 2020
@the-thing
QFJ-375 - configurable timeout multiplier (quickfix-j#288)
e39b69e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjohn chrjohn chrjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
QFJ 2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@the-thing @chrjohn