-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use clang's MSVC ABI #729
Conversation
Can't we detect this in CMake? |
You can detect it, but since it's a generally niche use-case, it didn't seem worth the extra complexity to me. |
I politely disagree :-) Let's see how much it really takes to get this right. Would this work?
|
The counterargument is that build options are really hard to remove once people start depending on them, so adding them should be done sparingly. |
This could work |
Can you give it a try? If it works we could just land that. |
It seems to work |
Fixes #728.
Adds
QJS_CLANG_MSVC_ABI
option, defaulted toOFF
. It doesn't linklibm
if it'sON
.I opted to have it be an option, because implementing behavior to check the clang target would add too much complexity.