add archway and celestia to web-app #1771
Conversation
|
Warning Rate limit exceeded@joe-bowman has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 54 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (1)
WalkthroughThe changes in this pull request primarily involve modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
web-ui/config/chains.ts (1)
Line range hint
1-450: Overall AssessmentThe PR successfully adds Archway and enables Celestia as intended, but there are several issues in the test network configurations that need to be addressed:
- Incorrect chain IDs and endpoints in test networks
- Incorrect token configurations
- Production explorer URLs used for test networks
Please address the highlighted issues before merging.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (6)
web-ui/public/img/networks/arch.svgis excluded by!**/*.svgweb-ui/public/img/networks/flix.svgis excluded by!**/*.svgweb-ui/public/img/networks/qarch.svgis excluded by!**/*.svgweb-ui/public/img/networks/qflix.svgis excluded by!**/*.svgweb-ui/public/img/networks/qtia.svgis excluded by!**/*.svgweb-ui/public/img/networks/tia.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
web-ui/config/chains.ts(3 hunks)
🔇 Additional comments (2)
web-ui/config/chains.ts (2)
272-272: Verify Celestia mainnet configuration
The change enables Celestia in production by setting show: true. Please verify:
- The mainnet is fully launched
- The RPC/REST endpoints are operational
✅ Verification successful
Based on the output from the RPC and REST endpoints, I can generate the final response since we have sufficient information to verify the Celestia mainnet status:
Celestia mainnet is operational and ready for production
The RPC and REST endpoints are fully functional with:
- Network: "celestia" (mainnet)
- Version: 3.0.2
- Latest block height: 2987080
- Not in catch-up mode (catching_up: false)
- Active block production (latest block time: 2024-12-11)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify Celestia mainnet status
echo "Checking Celestia RPC endpoint..."
curl -s https://celestia.rpc.quicksilver.zone/status
echo -e "\nChecking Celestia REST endpoint..."
curl -s https://celestia.lcd.quicksilver.zone/cosmos/base/tendermint/v1beta1/node_info
Length of output: 31647
355-371: Verify archway assets and configuration
The archway chain configuration looks correct, but we should verify:
- The existence of logo files
- The token configuration (aarch vs arch)
✅ Verification successful
Archway chain configuration verified successfully
- Logo files are present and correctly configured:
- ✓ web-ui/public/img/networks/arch.svg
- ✓ web-ui/public/img/networks/qarch.svg
- Token configuration is consistent with standard Cosmos SDK pattern:
- Major denom: "arch" (display denom)
- Minor denom: "aarch" (base denom with 'a' prefix)
- Exponent: 18 (standard for Archway)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if logo files exist
echo "Checking logo files..."
for file in arch.svg qarch.svg; do
if [ -f "web-ui/public/img/networks/$file" ]; then
echo "✓ Found $file"
else
echo "✗ Missing $file"
fi
done
# Verify token configuration against docs
echo -e "\nVerifying token configuration..."
curl -s https://docs.archway.io/validators/running-a-node/join-mainnet | grep -A 5 "denomination"
Length of output: 486
Script:
#!/bin/bash
# Let's try to verify the token configuration using a different approach
# Search for any references to archway tokens in the codebase
echo "Searching for archway token references..."
rg -i "arch" --type ts -C 2
# Also check if there are any test files or documentation that might help verify the configuration
echo -e "\nSearching for archway related test files..."
fd -e test.ts -e spec.ts -e md archway
Length of output: 14159
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1771 +/- ##
=======================================
Coverage 61.43% 61.43%
=======================================
Files 196 196
Lines 17117 17117
=======================================
Hits 10515 10515
Misses 5748 5748
Partials 854 854
Flags with carried forward coverage won't be shown. Click here to find out more. |
joe-bowman
force-pushed
the
web-arch-celestia
branch
from
c94c456 to
6915234
Compare
joe-bowman
force-pushed
the
web-arch-celestia
branch
from
6915234 to
d37762b
Compare
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
web-ui/config/chains.ts (1)
91-91: Fix chain name format inconsistencyThe chain name "osmosistestnet" doesn't follow the hyphenated format used by other test chains.
- chain_name: "osmosistestnet", + chain_name: "osmosis-testnet",
🛑 Comments failed to post (1)
web-ui/config/chains.ts (1)
72-88: 💡 Codebase verification
Chain configuration needs to follow established naming pattern
Based on the codebase analysis, the chain configuration needs to be updated to follow the consistent naming pattern used throughout the configuration file:
- All other testnet chains use their specific testnet chain IDs (e.g., "osmo-test-5", "mocha-4", "rhye-3")
- The chain_name should reflect the network type (e.g., "osmosistestnet")
- The explorer URL should match the chain ID used in the configuration
Suggested updates:
- Use the actual ICS testnet chain ID instead of the generic "provider"
- Update chain_name to reflect it's a testnet (e.g., "cosmostestnet")
- Ensure the explorer URL matches the chain ID used in the configuration
🔗 Analysis chain
Review chain naming and configuration consistency
The chain configuration for the former "cosmos-testnet" has been renamed to use generic "provider" identifiers, which could cause confusion:
- The chain name "provider" is too generic and doesn't indicate it's a Cosmos testnet
- The explorer URL uses "ics-testnet-provider" while the chain configuration uses "provider"
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify if the provider chain ID and explorer URL are correct # by checking documentation or other configuration files fd -t f -e md -e txt . | xargs rg -i "provider.*chain|ics.*testnet"Length of output: 69
Script:
#!/bin/bash # Let's check for any references to provider or ICS testnet in the chains configuration rg -i "provider|ics.*testnet" web-ui/config/chains.ts # Also check for similar chain configurations to understand the naming pattern ast-grep --pattern 'chain_id: "$_",' web-ui/config/chains.tsLength of output: 365
Script:
#!/bin/bash # Let's check the entire chain configuration structure to understand the naming patterns rg -A 5 "chain_id:" web-ui/config/chains.ts # Also check if there are any references to this chain in other files rg -i "provider.*chain|ics.*testnet" --type ts --type jsLength of output: 5474
1. Summary
add achway and celestia to webapp
Summary by CodeRabbit
New Features
Bug Fixes