-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokio version 1.23 breaks the tests #2571
Comments
fulmicoton
added a commit
that referenced
this issue
Dec 14, 2022
fulmicoton
added a commit
that referenced
this issue
Dec 14, 2022
fulmicoton
added a commit
that referenced
this issue
Dec 14, 2022
fulmicoton
added a commit
that referenced
this issue
Dec 14, 2022
fulmicoton
added a commit
that referenced
this issue
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upgrading the Tokio version 1.23 breaks the tests: CI Run
Tests pass without a problem on macOS and some Linux distros but fail on other instances.
My first instinct was this PR being responsible: tokio-rs/tokio#5223 since on the test:
test_mailbox_send_with_backpressure_counter_no_backpressure_cleansheet
we measure some backpressure on the zero capacity channels where we expect none:However, inserting
tokio::time::sleep(Duration::ZERO).await;
before sending the second message fixes the test. I am not sure what causes this, but my guess is context switch causes the task to resume after some time; in the meantime, theBackPressureActor
processes the message, and the channel becomes empty again.The text was updated successfully, but these errors were encountered: