Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spawn_blocking in leaf stream search #483

Closed
fmassot opened this issue Aug 29, 2021 · 0 comments · Fixed by #487
Closed

Use spawn_blocking in leaf stream search #483

fmassot opened this issue Aug 29, 2021 · 0 comments · Fixed by #487
Assignees
@fmassot
Labels
bug Something isn't working

Comments

@fmassot
Copy link
Contributor

fmassot commented Aug 29, 2021

To efficiently parallelize tasks with tokio, cpu heavy tasks need to be spawn using task::spawn_blocking.
@fmassot fmassot added the bug Something isn't working label Aug 29, 2021
@fmassot fmassot self-assigned this Aug 29, 2021
@fmassot fmassot mentioned this issue Aug 30, 2021
Merged
fmassot added a commit that referenced this issue Aug 31, 2021
@fmassot
Fix #483, #484 and above all handle errors happening in leaves.
1b11708
fmassot added a commit that referenced this issue Sep 1, 2021
@fmassot @guilload @fulmicoton
Fix #483, #484 and above all handle errors happening in search stream…
b76a468 
… leaves. (#487)

* Fix #483, #484 and above all handle errors happening in leaves.

* Add test on search stream with a leaf error.

* Add test on leaf search stream result.

* Add cli serve tests on a local file index.

* Fix typo in tests.

* Fix typo in test variable name.

Co-authored-by: Adrien Guillo <adrien@quickwit.io>

* Improve code syntax/readability.

* Fix fmt

Co-authored-by: Adrien Guillo <adrien@quickwit.io>
Co-authored-by: Paul Masurel <paul@quickwit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmassot fmassot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #483, #484 and above all handle errors happening in search stream leaves. quickwit-oss/quickwit
1 participant
@fmassot