plug exact count optimization #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Oct 25, 2023
fulmicoton
reviewed
Oct 25, 2023
fulmicoton
reviewed
Oct 25, 2023
fulmicoton
reviewed
Oct 25, 2023
fulmicoton
approved these changes
Oct 25, 2023
trinity-1686a
force-pushed
the
trinity--plug-opti
branch
from
45629a6
to
a6398d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #3997
does not impact #3998 as it would need more work. Tracing uses aggregations, which don't profit from that optimization yet
How was this PR tested?
created an index with single split documents, made a few query and verified
num_hitswas below what's expected whencount_all=false, and normal when it's true or absent