Issue/4469 limit concurrent merges #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/4469-limit-concurrent-merges
branch
4 times, most recently
from
032cd0c
to
e68efc6
Compare
fulmicoton
commented
Jan 30, 2024
| type ObservableState = MergePlannerState; | ||
|
|
||
| fn observable_state(&self) -> Self::ObservableState { | ||
| let ongoing_merge_operations = self |
There was a problem hiding this comment.
we now measure the number of onegoing merge operation in the merge scheduler.
fulmicoton
commented
Jan 30, 2024
| @@ -359,21 +354,12 @@ impl MergePlanner { | |||
| let tracked_merge_operation = self | |||
| .ongoing_merge_operations_inventory | |||
| .track(merge_operation); | |||
| if let Err(try_send_err) = self | |||
There was a problem hiding this comment.
That contraption was meant to avoid scheduling several large merge in a row.
fulmicoton
force-pushed
the
issue/4469-limit-concurrent-merges
branch
20 times, most recently
from
4e80b24
to
eb3a5a2
Compare
fulmicoton
force-pushed
the
issue/4469-limit-concurrent-merges
branch
2 times, most recently
from
2e56780
to
e20cf82
Compare
guilload
approved these changes
Jan 30, 2024
quickwit/quickwit-indexing/src/actors/merge_scheduler_service.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/actors/merge_scheduler_service.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/actors/merge_scheduler_service.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/actors/merge_scheduler_service.rs
Outdated
Show resolved
Hide resolved
fulmicoton
force-pushed
the
issue/4469-limit-concurrent-merges
branch
2 times, most recently
from
6f83d6f
to
af3822b
Compare
fulmicoton
force-pushed
the
issue/4469-limit-concurrent-merges
branch
2 times, most recently
from
f6abbb1
to
079ee8f
Compare
Co-authored-by: Adrien Guillo <adrien@quickwit.io>
fulmicoton
force-pushed
the
issue/4469-limit-concurrent-merges
branch
from
079ee8f
to
e9e047d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the merge scheduler to schedule merge operation in a global manner.
Closes #4469
Closes #4471
It was tested on a 10 pod cluster indexing 1000 indexes.