Use futures::stream in leaf functions #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
changed the title
fulmicoton
reviewed
Aug 25, 2021
| @@ -31,7 +32,8 @@ use quickwit_storage::Storage; | |||
| use std::sync::Arc; | |||
| use tantivy::schema::Type; | |||
| use tantivy::ReloadPolicy; | |||
| use tokio_stream::wrappers::UnboundedReceiverStream; | |||
|
|
|||
| const CONCURRENT_SPLIT_SEARCH_STREAM: usize = 2; | |||
There was a problem hiding this comment.
have you tested to see if it was not harming the perf too much?
fulmicoton
approved these changes
Aug 25, 2021
|
closing PR in favor of #487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / purpose
It could be useful to return
futures::streaminleaffunctions to:leaf_search_stream_single_splitorleaf_search_single_splitexecuted concurrentlySearchErrorto tonicStatusand vice versa, currentlyleaf_search_streamreturns an UnboundedReceiver with a result containing tonicstatus. We don't want to have this status at theleaf_search_streamlevel.Description
This PR shows how to use streams in
leaf_search_streamfunction and the subsequent changes we must apply to make the grpc layer compatible.Caveats
I did not manage to make the
SearchClientreturns a stream because of trait bounds error: the stream has to be Send + Sync but I only have a Send stream from tonic response. So I keep the unbounded receiver.