Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a StorageUriResolver singleton and a specific resolver for tests. #492

Merged
merged 7 commits into from
Sep 1, 2021
Merged

Add a StorageUriResolver singleton and a specific resolver for tests. #492

merged 7 commits into from
Sep 1, 2021

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Aug 30, 2021

Partially fix #478.

@fmassot fmassot marked this pull request as draft August 30, 2021 13:16
@fmassot fmassot mentioned this pull request Aug 30, 2021
Closed
@fulmicoton
Copy link
Contributor

LGTM, but can you review the commit I added?

@fmassot
Copy link
Contributor Author

fmassot commented Sep 1, 2021

Yes, I will do the merge too.

@fmassot fmassot marked this pull request as ready for review September 1, 2021 08:45
@fmassot fmassot merged commit ac7001b into main Sep 1, 2021
@fmassot fmassot deleted the issue/478 branch September 1, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird start times
2 participants
@fmassot @fulmicoton