Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing functional tests. #2239

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Fixing functional tests. #2239

merged 1 commit into from
Nov 5, 2023

Conversation

fulmicoton
Copy link
Collaborator

No description provided.

@fulmicoton fulmicoton force-pushed the fix-functional-tests branch from 84b5ff5 to 4f8925d Compare November 5, 2023 04:47
@adamreichold
Copy link
Collaborator

adamreichold commented Nov 5, 2023 •
edited
Loading

The failure to build SplitCompoundWordsFilter seems to be a Rust nightly bug, i.e. it does build using stable and the type AhoCorasick is still definitely Send + Sync in the current stable version of that crate. I reported this upstream at rust-lang/rust#117602

@fulmicoton
Copy link
Collaborator Author

ah thanks @adamreichold !

@fulmicoton fulmicoton merged commit 7bc5bf7 into main Nov 5, 2023
2 of 3 checks passed
@fulmicoton fulmicoton deleted the fix-functional-tests branch November 5, 2023 09:18
PSeitz pushed a commit that referenced this pull request Apr 10, 2024
@fulmicoton @PSeitz
Fixing functional tests. (#2239)
ecfd863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulmicoton @adamreichold