Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change handling of auto-generated traces in sequence diagram #49

Open
rmarx opened this issue Apr 19, 2021 · 0 comments
Open

Change handling of auto-generated traces in sequence diagram #49

rmarx opened this issue Apr 19, 2021 · 0 comments

Comments

@rmarx
Copy link
Member

rmarx commented Apr 19, 2021

Currently if you only upload 1 trace, we auto-generate its opposite in the sequence diagram (e.g., you upload client, qvis generates server)

This is done by doing a full copy of the original trace and then manually swapping packet_sent for packet_received and vice versa.

This is however quite wasteful, especially for large traces, and swapping sent/received is a bit confusing for several users if they click on the squares to watch event details. Additionally, we default to showing the client-side event in the detail popup, causing the generated qlog to show up if you upload a server-side trace instead of the server-side qlog, which is even more confusing.

I did this approach initially to make it easier to re-use code across single-trace and multi-trace setups. However, adding a bit of special code for single-trace scenarios should work too.

I do have a faint recollection that this was tried initially but was too difficult for some reason, so best to do some proper analysis before starting this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant