Comment about notational conventions #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
editorial
mikkelfj
reviewed
Jun 29, 2018
| @@ -106,6 +106,8 @@ The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", | |||
| document are to be interpreted as described in BCP 14 {{!RFC2119}} {{!RFC8174}} | |||
| when, and only when, they appear in all capitals, as shown here. | |||
|
|
|||
| This document uses terms and notational conventions from {{QUIC-TRANSPORT}}. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Shouldn't it be the other way around? Given that invariants are less likely to change.
There was a problem hiding this comment.
We decided that the transport doc should be standalone (that is, it does not depend on invariants normatively). v1 of the transport might eventually be obsolete, but the terminology will still be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone commented that we don't really explain what (i) means in diagrams, for instance.