Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore PR #73, accidentally reverted by 9f0c810 #81

Merged
merged 1 commit into from
Apr 18, 2019
Merged

fix: restore PR #73, accidentally reverted by 9f0c810 #81

merged 1 commit into from
Apr 18, 2019

Conversation

FezVrasta
Copy link
Contributor

@FezVrasta FezVrasta commented Apr 18, 2019 •
edited
Loading

PR checklist

  • I have followed the "Committing and publishing" guidelines;
  • I have added unit tests to cover my changes;
  • I updated the documentation and examples accordingly;

Changes description

restore PR #73, accidentally reverted by 9f0c810

image

Affected packages

  • @quid/react-core

cplazuelo
cplazuelo approved these changes Apr 18, 2019
View reviewed changes
Copy link

@cplazuelo cplazuelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@FezVrasta FezVrasta merged commit 54e2d8d into master Apr 18, 2019
@FezVrasta FezVrasta deleted the fix/restore_pr_73 branch June 4, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cplazuelo cplazuelo cplazuelo approved these changes

@vampolo vampolo Awaiting requested review from vampolo

@gabrielmicko gabrielmicko Awaiting requested review from gabrielmicko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FezVrasta @cplazuelo