Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI for forks #187

Merged
merged 1 commit into from
May 16, 2019
Merged

fix CI for forks #187

merged 1 commit into from
May 16, 2019

Conversation

pityonline
Copy link
Contributor

As an upstream, this repo depends on itself, but for a fork, it depends
on this repo. In Travis CI, install: true skipps go get for Go
projects, so the forks won't get the dependence and will cause the
CI failure. This is fixed by installing dependence in before_install.

Ref: https://docs.travis-ci.com/user/job-lifecycle/#skipping-the-installation-phase

As an upstream, this repo depends on itself, but for a fork, it depends
on this repo. In Travis CI, `install: true` skipps `go get` for Go
projects, so the forks won't get the dependence and will cause the
CI failure. This is fixed by installing dependence in `before_install`.

Ref: https://docs.travis-ci.com/user/job-lifecycle/#skipping-the-installation-phase
@pityonline
Copy link
Contributor Author

Here's an example of failing CI: https://travis-ci.com/studygolang/learn-go-with-tests/builds/111613911. Now it's passing.

@quii quii merged commit 8b72b2f into quii:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants