Add BLOCK-DIAG, MAP-BLOCKS, and PARTIAL-TRACE #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And BLOCK-MATRIX-P
| @@ -219,6 +219,11 @@ ELEMENT-TYPE, CAST, COPY-TENSOR, DEEP-COPY-TENSOR, TREF, SETF TREF)" | |||
| "Whether MATRIX is a unitary matrix" | |||
| (= matrix (conjugate-transpose matrix) epsilon)) | |||
|
|
|||
| (defun block-matrix-p (matrix) | |||
There was a problem hiding this comment.
Note: the general usage is that a "block matrix" is a matrix with an associated decomposition, e.g.
[[A, B, C],
[D, E, F]]
would be a valid block decomposition if nrows(A) = nrows(B) = nrows(C), ncols(A) = ncols(D), and so on. In this usage, the matrix doesn't have to be square. I'd suggest changing the name of your defun and adding a docstring if you want to keep the current behavior.
| @@ -379,6 +384,17 @@ If fast is t then just change layout. Fast can cause problems when you want to m | |||
| (loop :for i :below rows | |||
| :collect (tref matrix i i)))))) | |||
|
|
|||
| (defgeneric block-diag (matrix) | |||
There was a problem hiding this comment.
Same thing here -- seems like you have in mind specifically 2x2 block decompositions.
| (policy-cond:with-expectations (> speed safety) | ||
| ((assertion (block-matrix-p matrix))) | ||
| (let* ((dim (floor (sqrt (nrows matrix)))) | ||
| (freiche (zeros (list dim dim) :type type))) |
| @@ -146,6 +148,7 @@ | |||
| #:orthonormalize | |||
| #:orthonormalize! | |||
| #:trace | |||
| #:partial-trace | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And BLOCK-MATRIX-P