Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement QVM debugger. #245

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Implement QVM debugger. #245

merged 1 commit into from
Mar 24, 2020

Conversation

jmbr
Copy link
Contributor

@jmbr jmbr commented Mar 13, 2020

No description provided.

@jmbr jmbr requested a review from a team as a code owner March 13, 2020 16:56
@jmbr jmbr self-assigned this Mar 13, 2020
@jmbr jmbr requested review from appleby and notmgsk March 13, 2020 16:56
@notmgsk
Copy link
Member

notmgsk commented Mar 13, 2020 •
edited
Loading

So cool! A little asciinema demo would be e x t r a cool.

@jmbr
Copy link
Contributor Author

jmbr commented Mar 13, 2020

Wow, thanks!

appleby
appleby reviewed Mar 13, 2020
View reviewed changes
Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Can't wait to try it out.

I don't consider any of these blockers, just "comment"ing in case you want to address any of them

@jmbr
Copy link
Contributor Author

jmbr commented Mar 14, 2020

So cool! A little asciinema demo would be e x t r a cool.

There you go: https://asciinema.org/a/310051 !

@jmbr
Copy link
Contributor Author

jmbr commented Mar 14, 2020

This is awesome! Can't wait to try it out.

I don't consider any of these blockers, just "comment"ing in case you want to address any of them

This was really valuable feedback. Thank you.

appleby
appleby approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty

notmgsk
notmgsk suggested changes Mar 20, 2020
View reviewed changes
@jmbr jmbr force-pushed the feature/debugger branch from 477c33d to 3a6f054 Compare March 23, 2020 03:21
@jmbr jmbr force-pushed the feature/debugger branch from 3a6f054 to fea3b2d Compare March 23, 2020 03:27
@braised-babbage
Copy link
Contributor

This is very cool.

braised-babbage
braised-babbage approved these changes Mar 23, 2020
View reviewed changes
@jmbr jmbr merged commit 2d45449 into master Mar 24, 2020
@stylewarning stylewarning deleted the feature/debugger branch March 25, 2020 18:19
@appleby appleby mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby approved these changes

@braised-babbage braised-babbage braised-babbage approved these changes

@notmgsk notmgsk notmgsk approved these changes

Assignees

@jmbr jmbr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmbr @notmgsk @braised-babbage @appleby