Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install qvm to system in Docker builds #248

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Install qvm to system in Docker builds #248

merged 1 commit into from
Mar 20, 2020

Conversation

notmgsk
Copy link
Member

@notmgsk notmgsk commented Mar 19, 2020

No description provided.

@notmgsk notmgsk requested a review from a team as a code owner March 19, 2020 23:48
appleby
appleby approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the ENTRYPOINT also be changed to /bin/qvm since we're installing it?

@notmgsk
Copy link
Member Author

notmgsk commented Mar 20, 2020

Should the ENTRYPOINT also be changed to /bin/qvm since we're installing it?

👀 nah 👀

@appleby
Copy link
Contributor

appleby commented Mar 20, 2020

Should the ENTRYPOINT also be changed to /bin/qvm since we're installing it?

👀 nah 👀

absolute madlad

@notmgsk notmgsk merged commit 1ee19c0 into master Mar 20, 2020
@appleby appleby mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notmgsk @appleby