Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Request in constructor in RequestResponseDispatcher #10

Closed
quimcalpe opened this issue Nov 24, 2015 · 0 comments
Closed

Enforce Request in constructor in RequestResponseDispatcher #10

quimcalpe opened this issue Nov 24, 2015 · 0 comments
Labels
enhancement
Milestone
1.0

Comments

@quimcalpe
Copy link
Owner

With PR #3 it seems clear to me that Request must be passed and not be optional, as this is a BC break, target is 1.0 release.
@quimcalpe quimcalpe added this to the 1.0 milestone Nov 24, 2015
quimcalpe added a commit that referenced this issue Nov 24, 2015
@quimcalpe
Fix test broken with #10 change
4f392e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@quimcalpe