code still assumes memory layout? #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when a release with this fix will be made? We're trying to move our Rust compiler version forward, but everything breaks starting w/ 2022-08-01 without this change |
|
It looks like this was included in 0.8.4. Is that not working for you? |
|
Ah, looks like we're on quinn 0.8.4 but quinn-udp is still on 0.1.1. I can see the changes included in quinn-udp 0.1.3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that the IP types are changing in Rust... I also saw that this library updated in #987 but (and I could be wrong here) I think there's still an issue on recv? As far as I can tell,
decode_recvstill assumes the layout to be eithersockaddr_inorin_addrIf I'm misunderstanding something here, sorry. I am not a libc or unsafe expert by any stretch.
I copied some of the conversion code from mio: https://github.com/tokio-rs/mio/blob/master/src/sys/unix/net.rs#L143