Borrow self in read_to_end, rather than consuming
#1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows `RecvStream::stop` to be called with custom error codes if `ReadToEndError::TooLong` is encountered.
Ralith
force-pushed
the
read-to-end-borrow
branch
from
8eb450d
to
6893bca
Compare
djc
previously approved these changes
Mar 1, 2023
|
No strong feelings; is that the process you'd like to standardize on? |
|
My experience is that it's less error-prone, because going back and determining at release time whether there were semver-incompatible changes is a PITA. |
djc
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
RecvStream::stopto be called with custom error codes ifReadToEndError::TooLongis encountered.See also discussion in #1493.