Don't rely on sleeping in 0-RTT test #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unnecessarily racy, at least in principle.
djc
approved these changes
Apr 3, 2023
|
Nice! @nmittler FYI. |
|
Tangentially: a common cause of tests getting stuck until a timeout and then passing (which came up in previous related discussion) is relying on the implicit close-on-drop behavior and failing to drop something before calling |
|
@Ralith we should probably also add a test for 0-RTT being rejected here. That's where I'm running into a timing issue in the quinn-boring PR. There is a lower-level test for rejection under quinn-proto, but it doesn't suffer from the same timing problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unnecessarily racy, at least in principle.